To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=80769
User mba changed the following:
What |Old value |New value
================================================================================
Assigned to|as |fs
--------------------------------------------------------------------------------
Keywords| |regression
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Tue Aug 21 17:36:24 +0000
2007 -------
Frank, this is a problem with the basic code you added to binfilter. If any
non-binfilter document has been created before the binfilter basic module is
dysfunctional. ("-enableautomation" errornouosly always creates an empty Writer
doc and so triggers the bug.)
The following code in binfilter/bf_basic/source/basmgr/basmgr.cxx:
BOOL BasicManager::HasBasicWithModules( const SotStorage& rStorage, const
String& rBaseURL )
{
if( !rStorage.IsStream( ManagerStreamName ) )
return FALSE;
StarBASIC* pDummyParentBasic = new StarBASIC();
BasicManager* pBasMgr = new BasicManager( (SotStorage&)rStorage, rBaseURL,
pDummyParentBasic );
BOOL bRet = FALSE;
USHORT nLibs = pBasMgr->GetLibCount();
for( USHORT nL = 0; nL < nLibs; nL++ )
{
BasicLibInfo* pInfo = pBasMgr->pLibs->GetObject( nL );
StarBASIC* pLib = pInfo->GetLib();
if( !pLib )
{
BOOL bLoaded = pBasMgr->ImpLoadLibary( pInfo, NULL, FALSE );
if( bLoaded )
pLib = pInfo->GetLib();
}
if( pLib )
{
SbxArray* pModules = pLib->GetModules();
if( pModules->Count() ) // ***
{
bRet = TRUE;
break;
}
}
}
delete pBasMgr;
return bRet;
}
always returns "FALSE" in the marked code line when the bug is triggered. This
is different if the binary document is the first to be loaded.
This reminds me of a problem with SHL_PTR in Basic but AFAIR it was fixed by
Carsten. So it seems that there is another global variable that is shared
between binfilter's basic and the "other one".
In result basic from binary files is always lost as soon as the first non-binary
file was loaded. I have no idea if this is a showstopper but surely it's a
regression.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
