To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=75008
------- Additional comments from [EMAIL PROTECTED] Wed Aug 29 12:47:49 +0000 2007 ------- -> lijian: Two sophisticated problems will be not solved by your patch, I assume. 1. If you insert your file into a header of a document (with at least two pages). 2. If UpperFrm(..) delivers an empty pFrm and bBehind is false, you will crash. Some words to UpperFrm(..) vs. NextFrm(..) NextFrm(..) will deliver all SwFrm-occurrences of another SwNode, so you are able to insert a new SwFrm before or behind this delivered SwFrms. But NextFrm(..) is not able to handle situations where new layout frames have to be created because the new and the old SwNode are in different sections. UpperFrm(..) will always deliver a layout frame for insertion (sometimes self created frames) and it will deliver a pFrm which can be null e.g. if the new layout frame is empty. You should use UpperFrm(..) in each loop iteration to solve 1 and avoid the use of bBehind and pFrm->Next() for the Paste(..) method to avoid 2. Please have a look into SwCntntNode::MakeFrms(..) in node.cxx, where UpperFrm(..) is used accordingly. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
