To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=81139
User as changed the following:
What |Old value |New value
================================================================================
Status|NEW |RESOLVED
--------------------------------------------------------------------------------
Resolution| |INVALID
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Mon Sep 3 11:12:48 +0000
2007 -------
AS->pmladek: Thanks for your patch - but unfortunately it seams not to be the
right one. The code inside sfxhelp.cxx isnt realy used to retrieve the content
... its used to detect if the right help content suitable for the current locale
was installed. But thats wrong. Instead of scanning the directory tree the
return value of the used UCP should be scanned for errors.
The right patch would be ...
a) removing the method HelpLocaleString() completely.
b) Patch all different versions of method CreateHelpURL() so it uses a new
method called e.g. CreateHelpBaseURL(). Those new method creates the base URL
"vnd.sun.star.help://Language=<locale>&System=<system>".
c) Those base URL can be used to ask UCP for a small test content (to detect if
right help was installed successfully). see e.g.
"SfxContentHelper::GetResultSet( sHelpURL );" in line 816. If the result set
will be empty for the current locale ... a new base URL for "locale=en" should
be used as fallback. If those URL return an empty result set again ... an error
message must be shown (see line 820)
d) If a valid base URL could be created it should be cached instead to be
created new on every help request.
Doing so the sfxhelp class will be completely independend from any path or URL.
Thats the best solution - because the used UCP has to know the path to the real
help content only. These change will help us to place the help content e.g. on a
remote server (accessible via HTTP) which is currently not possible.
Of course then you have to patch module "xmlhelp" also .
Regards
Andreas
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
