To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=81612
User pjanik changed the following:
What |Old value |New value
================================================================================
Issue type|DEFECT |PATCH
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Sun Sep 16 18:00:34 +0000
2007 -------
The comments to the last patch:
extensions/source/abpilot/abspilot.cxx: use default: instead of
listing them all
extensions/source/abpilot/fieldmappingimpl.cxx: looks like it is an
adept to while cycle instead ;-)
extensions/source/bibliography/bibconfig.hxx: why do you change
header?
extensions/source/bibliography/bibcont.hxx: why do you change header?
extensions/source/bibliography/bibview.cxx:
Changes like this:
- e; // make compiler happy
- DBG_ERROR("::createGridModel: something went wrong !");
+ (void) e; // make compiler happy
+ DBG_ERROR("::createGridModel: something went wrong !");
change indentation of the second line - why?
I wonder who wrote original here, because there are 10+ times the same
code lines.
extensions/source/bibliography/loadlisteneradapter.hxx: change is OK,
but please take back indentation changes and the line deleted.
extensions/source/plugin/base/context.cxx: why do you change the class
declaration? Please fix the bad order inits...
extensions/source/propctrlr/genericpropertyhandler.cxx: changing
header/ order of private members: why?
extensions/source/scanner/sane.cxx (and other places):
Do not use such casts in C++ code!
+ if( (unsigned int) pZero->size > sizeof( SANE_Word ) )
use default: instead of listing all cases.
This code:
@@ -442,6 +443,9 @@
break;
case SANE_TYPE_FIXED:
case SANE_TYPE_INT:
+ case SANE_TYPE_BOOL:
+ case SANE_TYPE_STRING:
+ case SANE_TYPE_GROUP:
Is actually changing the meaning!
extensions/source/update/check/updatecheck.cxx:
- ShutdownThread *pShutdownThread = new ShutdownThread( m_xContext );
This actually can also change the behaviour if ShutDownThread is
creating the thread or something.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
