To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=81855
Issue #|81855
Summary|Merge OS2 port into dmake 4.11
Component|tools
Version|current
Platform|All
URL|
OS/Version|All
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|dmake
Assigned to|hjs
Reported by|vq
------- Additional comments from [EMAIL PROTECTED] Sat Sep 22 21:42:17 +0000
2007 -------
While resyncing cws_src680_dmake411 to m230 I found that dmake was ported to
OS2. Great, but unfortunately I found several issues with the changes that
where committed.
* C++ style comments. dmake is pure C, please refrain from using C++ comments.
* The change to Append_line() that converts whitespaces to newlines breaks
seems to be rather OOo build specific - $(mktmp ..) is not only used to
generate response files.
Beside that it also breaks the group shell functionality of dmake and
therefore should be solved differently. (Yes, I know it only breaks the OS2
version of dmake.)
The cleanest way to get the whitespace to newline transformation is either
to use the :m modifier when constructing the response file, i.e. like this:
MYRSPFILE := command1\ncommand2\ncommand3
someprog $(mktmp $(MYRSPFILE:m)
or to add a new control macro that allows for this behavior to be switched
on or of, see OOODMAKEMODE for an example how this is done.
* The change to Create_temp() is also not completely right, DirSepStr should
have been used, but this is an old bug.
* Several macro definitions are commented out. If they are unneeded they
should be removed.
* Is it true that the OS2 (EMX) command line is only 8192 and that there is
a process limit of 16? I ask because the change in unix/ruletab.c looks
unneeded.
* Why is CacheStat() disabled, i.e. defined to really_dostat()? The CacheStat()
function in unix/dcache.c should work, or be easily portable. If you do not
want to use the directory cache you can always set .DIRCACHE=n in your
startup file.
* No documentation was changed. If features are changed this has to be
documented in the man page. ChangeLog and NEWS file are also nice.
I will back out the questionable changes again in cws_src680_dmake411, please
file issues to me (vq) or hjs if I break something by taking out the changes.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
