To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=81574
------- Additional comments from [EMAIL PROTECTED] Fri Oct 5 19:20:47 +0000
2007 -------
@pkjanik :
In
sw/source/core/doc/number.cxx ( @@ -1263,7 +1263,7 @@ )
sw/source/core/unocore/unoobj2.cxx ( @@ -582,7 +582,7 @@ )
You used :
- sal_Unicode cChar;
+ sal_Unicode cChar = sal_Unicode();
And I don't understand the initialization using Sal_Unicode()
Reading sal/inc/sal/types.h, and if I'm not wrong, I understand Sal_Unicode is
sal_uInt16, and the first
initialization value I have in mind is 0 (NULL works, but probably not on all
systems)
Good catch in sw/source/core/table/swtable.cxx ( @@ -1500,7 +1500,7 @@ )
sw/source/filter/xml/xmltexte.cxx ( @@ -392,7 +392,7 @@ ), instead of :
- sal_Bool bIsAutoScroll, bIsScrollingMode;
+ sal_Bool bIsAutoScroll = sal_False, bIsScrollingMode;
I used :
- sal_Bool bIsAutoScroll, bIsScrollingMode;
+ sal_Bool bIsAutoScroll = sal_False;
+ sal_Bool bIsScrollingMode = sal_False;
But this is cosmetic change
Same a bit later, in the same file ( @@ -401,7 +401,7 @@ )
- sal_Bool bIsBorderSet, bIsAutoBorder;
+ sal_Bool bIsBorderSet, bIsAutoBorder = sal_False;
Good catch too for:
sw/source/ui/index/cnttab.cxx 2007-09-14 11:58:31.000000000 +0200
@@ -1232,7 +1232,7 @@
//-----------------------------------------------------------------
CurTOXType lcl_UserData2TOXTypes(sal_uInt16 nData)
{
- CurTOXType eRet;
+ CurTOXType eRet = CurTOXType();
(I was stuck with it )
For all other changes, I completely agree ( I did the same in my own patch )
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
