To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=81612
------- Additional comments from [EMAIL PROTECTED] Sat Oct 6 12:39:49 +0000 2007 ------- @ericb: With the above patch, you have two times the code waitpid( m_nCommPID, &status, WUNTRACED ) , once for debug builds, and once for non-debug builds. If somebody decides to, say, replace &status with something else, then chances are good that one of the two incarnations is overlooked - this is what I mean with getting out of sync. Such a problem is rather theoretic in this particular case, since both incarnations are close to each other. It's just a matter of principle. I learned that duplicated code leads to fixing bugs (or changing facets) in one incarnation only, and not in all duplicates ... That said, all suggested patches are fine. It's just a matter of taste. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
