To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=79179
------- Additional comments from [EMAIL PROTECTED] Thu Oct 11 10:52:50 +0000
2007 -------
Here's the code, reduced to what I think is relevant:
SfxPoolItemArray_Impl *pNewArr = 0;
SfxPoolItem *pDefItem = 0;
if ( bKnownItem )
{
if ( !bOwnPool )
nWhich = nMappedWhich;
USHORT nIndex = GetIndex_Impl(nWhich);
ppArr = pImp->ppPoolItems + nIndex;
pNewArr = new SfxPoolItemArray_Impl( nCount );
pDefItem = *(ppStaticDefaults + nIndex);
}
ULONG nLastPos = rStream.Tell();
if ( !bSecondaryLoaded && pSecondary && pDefItem->ISA(SfxSetItem) )
{
rStream.Seek(nEndOfSizes);
CHECK_FILEFORMAT_RELEASE( rStream, SFX_ITEMPOOL_TAG_ENDPOOL,
pNewArr );
CHECK_FILEFORMAT_RELEASE( rStream, SFX_ITEMPOOL_TAG_ENDPOOL,
pNewArr );
pSecondary->Load1_Impl( rStream );
bSecondaryLoaded = TRUE;
nSecondaryEnd = rStream.Tell();
rStream.Seek(nLastPos);
}
for ( USHORT j = 0; j < nCount; ++j )
{
ULONG nPos = nLastPos;
rStream >> nRef;
if ( bKnownItem )
{
// some lines snipped
pNewArr->C40_INSERT( SfxPoolItem, pItem, j); //!!!
// restliche gespeicherte Laenge skippen (neueres Format)
nLastPos = rStream.Tell();
}
// some lines snipped
}
if ( bKnownItem )
{
SfxPoolItemArray_Impl *pOldArr = *ppArr;
*ppArr = pNewArr; // !!!
What prevents the access to pNewArr at the marked places?
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
