To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=45007
                  Issue #:|45007
                  Summary:|crasher / filter list length ...
                Component:|Word processor
                  Version:|680m79
                 Platform:|Other
                      URL:|
               OS/Version:|All
                   Status:|NEW
        Status whiteboard:|
                 Keywords:|
               Resolution:|
               Issue type:|PATCH
                 Priority:|P2
             Subcomponent:|code
              Assigned to:|mru
              Reported by:|mmeeks





------- Additional comments from [EMAIL PROTECTED] Mon Mar 14 07:28:29 -0800 
2005 -------
So - the new libwpd filter re-work didn't update the length of the list of
filters correctly. This causes some nasty crashers - due to some rather fragile
detection code. Particularly IsFilter('') would return TRUE for the bogus NULL
item at the end of the filters list.

Since this is the 2nd time this has bitten me, the patch adds a check for this
case, as well as fixing the length:


--- sw/inc/iodetect.cxx 28 Jan 2005 15:26:05 -0000      1.19
+++ sw/inc/iodetect.cxx 14 Mar 2005 15:28:03 -0000
@@ -101,7 +101,7 @@
 
        inline int IsFilter( const String& rNm )
        {
-               return rNm.EqualsAscii( pName, 0, nLen );
+               return pName && rNm.EqualsAscii( pName, 0, nLen );
        }
 
 #ifdef _DLL_
@@ -159,7 +159,7 @@
                1 +
 #endif
         //21;
-        19;
+        18;
 
 #define FORAMTNAME_SW4                 "StarWriter 4.0"
 #define FORAMTNAME_SW3         "StarWriter 3.0"

HTH.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to