To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=82235


User mba changed the following:

                What    |Old value                 |New value
================================================================================
             Assigned to|mba                       |mav
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Thu Oct 25 13:14:26 +0000 
2007 -------
It seems to be a regression caused by the fix for issue 55790.

Mikhail, the bug lies in SwDocShell::SetModified(). It doesn't send out any
notifications anymore.

It is obviously wrong to prevent the Broadcast of HINT_DOCCHANGED in case of
pDoc being in OLECallback. So I opt for the following change:

old :

        if( IsEnableSetModified() && !pDoc->IsInCallModified() )
        {
                EnableSetModified( FALSE );

                if( bSet )
                {
                        BOOL bOld = pDoc->IsModified();
                        pDoc->SetModified();
                        if( !bOld )
                                pDoc->SetUndoNoResetModified();
                }
                else
                        pDoc->ResetModified();

                EnableSetModified( TRUE );

                UpdateChildWindows();
                Broadcast(SfxSimpleHint(SFX_HINT_DOCCHANGED));
        }


new:

if( IsEnableSetModified() ) 
        {
                if ( !pDoc->IsInCallModified() )
                {
                        EnableSetModified( FALSE );

                        if( bSet )
                        {
                                BOOL bOld = pDoc->IsModified();
                                pDoc->SetModified();
                                if( !bOld )
                                        pDoc->SetUndoNoResetModified();
                        }
                        else
                                pDoc->ResetModified();

                        EnableSetModified( TRUE );
                }

                UpdateChildWindows();
                Broadcast(SfxSimpleHint(SFX_HINT_DOCCHANGED));
        }



---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to