To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=82684
------- Additional comments from [EMAIL PROTECTED] Mon Nov 5 10:28:11 +0000
2007 -------
The whole idea of calling checkSpecialCharacters in keyDown was that some keys
should not be swallowed by the input manager. If we pass key events to the input
manage first, then we should scrap checkSpecialCharacters wholesale. At the
moment with your patch if you press Ctrl-shift-j you get into full screen mode
and back again, because the event is dispatched twice - unless you happen to
have the input method which swallows that key event.
Since it simplifies the code, I'd vote to remove the block
bool bHandleCommandKey = mpFrame->mpMenu ? false : true;
if( (mpFrame->mnLastModifierFlags & NSControlKeyMask) ||
( (mpFrame->mnLastModifierFlags & NSCommandKeyMask) &&
bHandleCommandKey )
)
{
// note: checkSpecialCharacters sets mbInKeyInput to false as a side
effect
// if the event is consumed
if ( [self checkSpecialCharacters:pEvent] )
return;
}
Any conflicts that occur between input manager and our shortcuts will have to be
solved somehow by OOo using other shortcus.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
