To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=83014
User pjanik changed the following:
What |Old value |New value
================================================================================
CC|'aw,cmc,fs,kendy,mba,os' |'aw,cmc,dr,fs,kendy,mba,os
| |'
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Mon Nov 26 08:17:28 +0000
2007 -------
dr: you seems to owner the file svx/source/dialog/numfmt.cxx:
The original set of warnings is:
849: warning: comparison is always false due to limited range of data type
1115: warning: large integer implicitly truncated to unsigned type
1353: warning: comparison is always false due to limited range of data type
1647: warning: large integer implicitly truncated to unsigned type
After
--- ../../../../ooo_SRC680_m238_src.orig/svx/source/dialog/numfmt.cxx
2007-11-26
08:13:49.000000000 +0100
+++ ./numfmt.cxx 2007-11-26 09:04:59.000000000 +0100
@@ -85,7 +85,7 @@
#endif //CHINA001
#include <sfx2/app.hxx> //CHINA001
#include "flagsdef.hxx" //CHINA001
-#define NUMKEY_UNDEFINED ULONG_MAX
+#define NUMKEY_UNDEFINED SAL_MAX_UINT32
// static ----------------------------------------------------------------
the new set of warnings is only:
/home/oo/BuildDir/ooo_SRC680_m238_src/svx/source/dialog/numfmt.cxx:1353:
warning:
comparison is always false due to limited range of data type
This line is:
if ( aLbFormat.GetSelectEntryPos() == LIST_APPEND )
GetSelectEntryPos() returns USHORT and LIST_APPEND is defined as ULONG_MAX.
Thus this part of the
code is never reached on 64bit machines.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
