To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=83367
User bm changed the following:
What |Old value |New value
================================================================================
Assigned to|bm |mba
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Mon Nov 26 09:57:12 +0000
2007 -------
->MBA: Well, the old code was:
if ( SvtModuleOptions().IsChart() )
xObj = pDocShell->GetEmbeddedObjectContainer().CreateEmbeddedObject(
SvGlobalName( SO3_SCH_CLASSID ).GetByteSequence(), aNameString );
if ( xObj.is() )
{
String aObjName = aNameString; // wirklich eingefuegter Name...
The code after your change is:
::rtl::OUString aTmp( aNameString ); // ! Copy aNameString to a new stack
variable !
if ( SvtModuleOptions().IsChart() )
xObj = pDocShell->GetEmbeddedObjectContainer().CreateEmbeddedObject(
SvGlobalName( SO3_SCH_CLASSID ).GetByteSequence(), aTmp ); // ! Now uses aTmp
instead of aNameString !
if ( xObj.is() )
{
String aObjName = aNameString; // wirklich eingefuegter Name...
So, this was an explicit change NOT to use aNameString in the call to
CreateEmbeddedObject. (aNameString is not used later in the code, and is a
stack-variable, too. That means, introducing aTmp must have had the intention to
apply an unmodified, in the current situation an empty, aNameString in the last
line of this code fragment).
I ask myself: why? And as you did the change, I suppose at least at the time you
did the change, you knew why this was done.
If you don't remember, please forward the issue to Niklas.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
