To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=83548


User kendy changed the following:

                What    |Old value                 |New value
================================================================================
                      CC|'tbe'                     |'mmeeks,tbe,thb'
--------------------------------------------------------------------------------
             Assigned to|kendy                     |sb
--------------------------------------------------------------------------------
              Issue type|DEFECT                    |PATCH
--------------------------------------------------------------------------------
        Target milestone|---                       |OOo 2.4
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Tue Nov 27 22:02:37 +0000 
2007 -------
The thing is that osl_getAbsoluteFileURL_impl_() is not the most cunning 
function under the sun - it seems to call realpath() on each and every piece 
of the path - apparently to be able to work even when the path does not exist.  
(I mean, to resolve /ugh/blah/haha.txt, it calls realpath() first on /ugh, 
then /ugh/blah, etc.)  A side effect of realpath() is that it resolves 
symlinks, which I'm not sure is wanted in each and every case.  So - from my 
point of view, I see several possible improvements here:

- osl_getAbsoluteFileURL_impl_() could first try to call realpath(), and if, 
and only if, the file/directory does not exist, do the manual removal of '.' 
and '..'.  It could even iterate from back to front so that the first 
non-failing realpath() would give us the path we want & the reason to end the 
iteration

- osl_getAbsoluteFileURL_impl_() would not expand 'basename' symlink, just the 
symlinks that are in the 'dirname' part - that's in fact what my patch does 
when OOO_ALLOW_LINKOO_SYMLINKS is exported.  I see no bad behavior with that 
so far - what risks are here, please?

Of course - if the above is not viable, let's please at least apply the patch 
with the OOO_ALLOW_LINKOO_SYMLINKS distinction.  Not being able to use linkoo 
is really painful.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to