To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=45209
                  Issue #:|45209
                  Summary:|Duplicate symbols across components ...
                Component:|Spreadsheet
                  Version:|680m79
                 Platform:|All
                      URL:|
               OS/Version:|All
                   Status:|NEW
        Status whiteboard:|
                 Keywords:|
               Resolution:|
               Issue type:|PATCH
                 Priority:|P2
             Subcomponent:|code
              Assigned to:|spreadsheet
              Reported by:|mmeeks





------- Additional comments from [EMAIL PROTECTED] Wed Mar 16 09:36:28 -0800 
2005 -------
So - having chased this vicious excel import memory corruptor for some hours, I
came up with this pathetic patch: essentially Excel import uses an object
'ColRowSettings' - which is fine, except writer also uses a similar class - and
well; you'd never know until the virtual destructor is called that frees
something it should never free [ prolly only on Unix ], and then OO.o starts
scribbling all over the heap (double frees etc.). [ of course, this only happens
sometimes ].

I attach a sample document and a patch.

What most concerns me is: was there no audit of this sort of thing done when we
binned the tiny map-files ? ie. I guess this doesn't affect 1.1 because we only
export a trivial symbol-set. Matthias - what is the status there ?

Should there be an effort to namespace each component into 'sc', 'sw' etc. ? [
adding yet more bulk to our symbol tables ;-) ]. I'm guessing it should be
fairly easy to write some tooling to catch this sort of thing - duplicate
constructors would prolly be a good bet (?).

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to