To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=86171
------- Additional comments from [EMAIL PROTECTED] Fri Feb 22 12:05:31 +0000
2008 -------
Looks like the correct approach in general. However, since the previous
condition
if ( rErr || ((ScFormulaCell*)pCell)->IsValue() )
already obtained IsValue() during the boolean short-circuit (if the condition
does not match, IsValue() returned false) that doesn't need to be evaluated
again, the resulting code could be simplified to something like (untested and
off-hand)
if ( rErr || ((ScFormulaCell*)pCell)->IsValue() )
...
else if ( bTextAsZero )
...
Did you check the other interpreter cases where the ScValueIterator is used with
bTextAsZero? Did they exhibit wrong behavior as well that now is fixed?
Thanks
Eike
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
