To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=86775
User er changed the following:
What |Old value |New value
================================================================================
Target milestone|--- |OOo 3.0
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Sat Mar 29 14:03:02 +0000
2008 -------
Hi Kohei,
Nice patch. Some small nitpick ;-) instead of
if (::rtl::math::isNan(fValue) || ::rtl::math::isInf(fValue) ||
fValue == HUGE_VAL || fValue == 0.0)
please use
if (!::rtl::math::isFinite(fValue) || fValue == 0.0 || fValue == HUGE_VAL)
isFinite() checks for both, NAN and INF, using the platform dependent
SAL_MATH_FINITE(), and internally isNan() and and isInf() use the same but do
extra work to determine whether it's a NAN or INF then, which is unnecessary
here.
For the round() we may use ::rtl::math::round() instead, that also allows
control over the rounding mode, compiler libraries maybe differ in their
internal implementation of round().
I think we might use floor(approxValue()) also in other places where up to now
we use approxFloor(), what do you think? If so, we could add that as
::rtl::math::approxValue() and maybe should simply change the
::rtl::math::approxFloor() and ::rtl::math::approxCeil() methods to use that,
and then would get rid of their threshhold behavior as well. Just a quick idea,
could you imagine any negative side effect when doing so?
Thanks
Eike
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
