To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=87197
------- Additional comments from [EMAIL PROTECTED] Fri Apr 4 07:52:31 +0000 2008 ------- The current implementation is buggy in two aspects: - the problem mentioned by Ingrid - the code called in "modified" calls into sfx-code without using SolarMutex The simplest and IMHO best fix would be to use the SolarMutex in the listener. We don't get anything useful from using an own Mutex here. On the contrary: from past experience we know that guarding objects with members that itself use "Solar based" code by an own mutex creates a huge risk for crashes and deadlocks. Only code that does not use any library like vcl, sfx2 etc. can safely be implemented with an own mutex. Such code is a time bomb. I don't know if the IModifiableDocument implementation in base uses an own mutex - for the mentioned reasons I would strongly discourage to do so. But if uses the SolarMutex somewhere in its code anyway we would benefit from using it in the listener also. If the Base module has a problem: then we shouldn't reuse the listener implementation from sfx2. At the end it's only three methods, one is empty, two are two-liners. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
