To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=5226
------- Additional comments from [EMAIL PROTECTED] Thu Apr 10 13:31:19 +0000
2008 -------
The corrected fix is available from cvs (revision 1.102.24.1 of objserv.cxx).
The bug was that the patch allows to save read-only documents what usually will
create an error message or at least will do nothing (didn't test it). Both are a
bad user experience IMHO.
The code in objserv.cxx should be
case SID_SAVEDOC:
{
BOOL bMediumRO = IsReadOnlyMedium();
if ( !bMediumRO && GetMedium() )
rSet.Put(SfxStringItem( nWhich, String(SfxResId(STR_SAVEDOC))));
else
rSet.DisableItem(nWhich);
}
break;
The code checks for readonly files. The attached patch does nothing in that case
and giving no state still does not disable anything, the slot stays enabled.
BTW: the GetMedium() condition is only of theoretical interest, it shouldn't
happen ever, but in case it happens the "Save" command execution surely will
lead to a crash. So I think disabling is also appropriate in that case.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
