To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=88874





------- Additional comments from [EMAIL PROTECTED] Tue May 13 12:18:07 +0000 
2008 -------
mod->fme:

shells/txtsh1.cpp as well as lingu/olmenu.cxx is using this stuff as well, there
is also lots of duplicate code in the sense of 

void lcl_SetLanguage( SwWrtShell& rWrtSh, const String &rLangText, bool
bIsForSelection, SfxItemSet &rCoreSet)

void lcl_SetLanguage(SwWrtShell &rWrtSh, EditEngine* pEditEngine,ESelection
aSelection, const String &rLangText, bool bIsForSelection, SfxItemSet 
&rCoreSet);

which share almost exactly the same code.

Proposal:

- merge all these duplicate function into one, if EditEngine is 0, it will be
for the document, otherwise for the EditEngine
- change SwShellHelper to SwLangHelper
- move header back to ui/inc

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to