To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=89545
Issue #|89545
Summary|Too large mnDescent for some fonts on Mac OS X
Component|gsl
Version|DEV300m12
Platform|Macintosh
URL|
OS/Version|Mac OS X
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|DEFECT
Priority|P3
Subcomponent|code
Assigned to|hdu
Reported by|ekato
------- Additional comments from [EMAIL PROTECTED] Fri May 16 07:16:00 +0000
2008 -------
Some fonts on Mac OS X are rendered with large descent size, and it causes these
fonts aligned upward. For example "Poplar Std", "ROSEWOOD STD REGULAR" in the
attached figures (fontmenu-non-patched.png and fontmenu-patched.png).
This symptom applies for Hiragino fonts, which is the default UI fonts for ja
version, and this causes text rendered in UI dialog a bit funny
(ja-ui-non-patched.png and ja-ui-patched.png).
@hdu: Is there any particular reason that aMetrics.leading is currently added
for pMetric->mnDescent? The figures with patched one are created with following
diff.
Index: salgdi.cxx
===================================================================
RCS file: /cvs/gsl/vcl/aqua/source/gdi/salgdi.cxx,v
retrieving revision 1.68.32.6
diff -u -r1.68.32.6 salgdi.cxx
--- salgdi.cxx 8 May 2008 16:13:47 -0000 1.68.32.6
+++ salgdi.cxx 16 May 2008 06:29:25 -0000
@@ -1412,8 +1412,8 @@
// please see the comment in AquaSalGraphics::SetFont() for details
const double fPixelSize = (mfFontScale * mfFakeDPIScale * fPointSize);
pMetric->mnAscent = static_cast<long>(+aMetrics.ascent * fPixelSize
+ 0.5);
- pMetric->mnDescent = static_cast<long>((-aMetrics.descent +
aMetrics.leading) * fPixelSize + 0.5);
- pMetric->mnIntLeading = 0;
+ pMetric->mnDescent = static_cast<long>(-aMetrics.descent * fPixelSize
+ 0.5);
+ pMetric->mnIntLeading = static_cast<long>(aMetrics.leading * fPixelSize +
0.5);
pMetric->mnExtLeading = 0;
// ATSFontMetrics.avgAdvanceWidth is obsolete, so it is usually set to zero
// since ImplFontMetricData::mnWidth is only used for stretching/squeezing
fonts
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
