To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85991
------- Additional comments from [EMAIL PROTECTED] Fri May 23 08:14:45 +0000
2008 -------
fme->tora: Thank you for your patch. This is really quite a lot of code changes
;-) I had a first look at your patch and like to give you some feedback. First,
I have set up a cws ('rubyadjust') and committed your patch to that cws. Please
make any further patches basing on this cws, this way it is much easier for us
to have your work in sync with the current milestones. So here are my comments:
1. Shouldn't we initialize the ruby height values in the constructor instead of
WhichTxtPor()?
2. I see that in ::PaintMultiPortion the meaning of bHasGrid has changed. Is
this intended?
3. I'd like to make sure that the overall layout of the document has to remain
stable for existing documents. If the position of the glyphs inside a line
change, that's acceptable. But we should avoid changing e.g., line heights. I
think the code in ::CalcRealHeight might change the layout of existing
documents, is this correct? In this case I suggest to implement a new (hidden)
compatibility flag (see doc.hxx) that makes sure that any layout related code
changes do not affect old documents.
4. Please add some more comments to the changed code, this way it is much easier
for me to review your changes.
5. Some of the new members nRubyHeight* in SwLinePortion are only set for ruby
multi portions I guess. In this case I suggest to move the values to the multi
portion.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
