To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=89844
                 Issue #|89844
                 Summary|Move ExtLeading below the text line
               Component|Word processor
                 Version|DEV300m12
                Platform|Macintosh
                     URL|
              OS/Version|Mac OS X
                  Status|UNCONFIRMED
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|PATCH
                Priority|P3
            Subcomponent|code
             Assigned to|hdu
             Reported by|ekato





------- Additional comments from [EMAIL PROTECTED] Fri May 23 10:02:02 +0000 
2008 -------
With fixing issue #89545 in cws_aquavcl08, now fonts on Mac OS X become rendered
with proper ascent and descent, which fixes UI text rendering at the right
positioning.

However, as its leading is now assigned as mnExtLeading instead of addition for
mnDescent, sw documents show these ExtLeading above the text lines.  But typical
Mac OS X application put these leadings below the text lines, the layout of
document made by sw looks different compared with Apple's Pages application.  So
I'd suggest moving these ExtLeading below the text line for Aqua with changes 
below.


Index: fntcache.cxx
===================================================================
RCS file: /cvs/sw/sw/source/core/txtnode/fntcache.cxx,v
retrieving revision 1.95
diff -u -r1.95 fntcache.cxx
--- fntcache.cxx        10 Apr 2008 15:50:58 -0000      1.95
+++ fntcache.cxx        23 May 2008 09:52:12 -0000
@@ -347,7 +347,11 @@
     {
         CreateScrFont( *pSh, rOut );
         ASSERT( USHRT_MAX != nScrAscent, "nScrAscent is going berzerk" )
+#if defined(MACOSX)
+        nRet = nScrAscent;
+#else
         nRet = nScrAscent + GetFontLeading( pSh, rRefDev );;
+#endif
     }
     else
        {
@@ -361,7 +365,11 @@
             ( (OutputDevice&)rRefDev).SetFont( aOldFnt );
                }
 
+#if defined(MACOSX)
+        nRet = nPrtAscent;
+#else
         nRet = nPrtAscent + GetFontLeading( pSh, rRefDev );;
+#endif
        }
 
     ASSERT( USHRT_MAX != nRet, "GetFontAscent returned USHRT_MAX" )

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to