To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=89031


User sb changed the following:

                What    |Old value                 |New value
================================================================================
                      CC|''                        |'sb'
--------------------------------------------------------------------------------
             Assigned to|tm                        |iha
--------------------------------------------------------------------------------




------- Additional comments from [EMAIL PROTECTED] Tue Jun  3 16:32:29 +0000 
2008 -------
svx/source/unodialogs/textconversiondlgs/chinese_direction_tmpl.hrc:1.6 contains
three defines, of which the first two (RB_TO_SIMPLIFIED, RB_TO_TRADITIONAL) can
meaningfully be used in both cxx and src files, while the last, problematic one
(DIRECTION_RADIOBUTTONS) can only meaningfully be used in src files (as its
expansion is not C++ code, and the corresponding definition from the localized
chinese_direction.hrc contains non-ASCII bytes, which are forbidden in OOo's
C/C++ source code).  Hence, I would assume the best fix is to split
chinese_direction_tmpl.hrc in two, moving the "good" defines into one file and
the "bad" define into another (which then is only included from src files, not
from cxx files).

@iha:  It appears you originally introduced
svx/source/unodialogs/textconversiondlgs/chinese_direction.hrc (which then was
moved to chinese_direction_tmpl.hrc), so can you please take care of this? 
(Also, please note <#desc4>, which lists further places in the code that might
have the same problem.)

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to