To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=90426





------- Additional comments from [EMAIL PROTECTED] Fri Jun 27 11:54:55 +0000 
2008 -------
sb: Maybe I wouldn't change the ULONGs to sal_Size, because the 
SvOutputStreamOpenLockBytes has ULONG in the declarations; and 
SvLockBytesInputStream::available(), the 
static_cast<sal_uInt32>(SAL_MAX_UINT32), didn't you mean 
static_cast<sal_Size>(SAL_MAX_UINT32) [or maybe just let there the ::std::min 
as before, but using sal_Int32 there instead of sal_uInt32]?

But most probably this is just nitpicking ;-) - and the 'if (m_nPosition + 
nBytesToSkip < 0)' is really a nice catch! :-)

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to