To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=35913





------- Additional comments from [EMAIL PROTECTED] Thu Sep 18 22:26:42 +0000 
2008 -------
I've updated the patch to address the 2nd and 3rd issues that nn raised.

> - Eike's suggestion "Multiline meMultiline : 2" doesn't work with MSVC, 
> because
> it uses (signed) int as the default underlying type for enums.

I simply removed the trailing :2 size specifier.  Will this be enough?  We 
(William and I) don't seem to have a good Windows develoment environment, so 
any suggestion for this would be appreciated if this change will not be 
adequate.

> - Kohei's change, with ScXMLExport::IsMultiLineFormulaCell always calling
> ScDocument::GetCell, adds some performance overhead. I didn't measure it, but
> load/save is something we don't want to slow down (at least if multiple-line
> formula results aren't used).

I've made some change so that ScDocument::GetCell() gets called only once.


---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to