To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=60594
------- Additional comments from [EMAIL PROTECTED] Fri Oct 17 08:21:11 +0000 2008 ------- @fme: I would like to go over the vcl stuff once more. Other things that come to my mind: 1. When I validate the kashida positions in itradj.cxx, I set the layout mode as following: > ULONG nOldLayout = rInf.GetOut()->GetLayoutMode(); > rInf.GetOut()->SetLayoutMode ( nOldLayout | TEXT_LAYOUT_BIDI_RTL ); > nKashidasDropped = rInf.GetOut()->ValidateKashidas ( ...); > rInf.GetOut()->SetLayoutMode ( nOldLayout ); When wrote this, I wasn't really sure what is required. I found out that I need to set the TEXT_LAYOUT_BIDI_RTL flag to get correct results for LTR paragraphs. But since this has been done more by "trial and error" and not by knowing, I'd be glad, if you give it a thought. 2. We haven't dealt with your comments on the data structures: > I think using a sorted array (or a more 'modern' data structure > like std::set) is more suitable for the kashida array, since right > now IsKashidaInvalid/ClearKashidaInvalid always have to iterate the > whole array. @hdu: Can you comment on my remarks from 25/9? --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
