To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=95656
                 Issue #|95656
                 Summary|Superfluous ProductPatch variable
               Component|Installation
                 Version|OOO300m9
                Platform|All
                     URL|
              OS/Version|All
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|DEFECT
                Priority|P3
            Subcomponent|code
             Assigned to|is
             Reported by|sb





------- Additional comments from [EMAIL PROTECTED] Thu Oct 30 15:26:13 +0000 
2008 -------
As discovered in OOO300m11 (i.e., on the way to OOo 3.0.1), the About box still
displays brand layer version ini-file ProductPatch value (even with fixes for
issue 94693 and issue 94575 integrated), and at least for some products this
variable is indeed set (via WINDOWSPATCHLEVEL variable, see
solenv/bin/modules/installer/scriptitems.pm:1.51.18.2 l. 732), but issue 94693
does not specify that any such information shall be displayed in the About box.

The minimal fix for OOo 3.0.1 would thus be to remove setting the productupdate
variable (and thus the ProductPatch variable) to anything but an empty string in
solenv/bin/modules/installer/scriptitems.pm:1.51.18.2.

Further cleanup should include the following:
- Remove the settings of ProductPatch variables in URE layer bin-directory
version ini-file (scp2/source/ooo/ure.scp:1.12.2.1 l. 1181) and basis layer
program-directory version ini-file (scp2/source/ooo/profileitem_ooo.scp:1.67.4.1
l. 613), which appear to be not used anywhere, anyway.
- Remove the setting of ProductPatch variable in SO brand layer
program-directory bootstrap ini-file (scp2so/source/office/so_brand.scp:1.4.2.1
l. 38), which appears to be obsolete, anyway (see
unotools/source/config/bootstrap.cxx:1.28 l. 688).
- Remove support for productupdate variable from
solenv/bin/modules/installer/scriptitems.pm:1.51.18.2 completely.
- Remove utl::Bootstrap::getProductPatchLevel
(unotools/inc/unotools/bootsrap.hxx:1.15 l. 67) and its sole use at
sfx2/source/dialog/about.cxx:1.41 l. 173.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to