To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96083
Issue #|96083
Summary|goodies: dubious && and ||
Component|Drawing
Version|DEV300m31
Platform|All
URL|
OS/Version|Linux
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|PATCH
Priority|P3
Subcomponent|code
Assigned to|sj
Reported by|cmc
------- Additional comments from [EMAIL PROTECTED] Tue Nov 11 09:09:52 +0000
2008 -------
X && Y || Z
binds operator precedence-wise as...
(X && Y) || Z
There are three suspicious cases of this in goodies
i.e.
source/filter.vcl/eps/eps.cxx
while ( ( --nSecurityCount ) && ( *pDest == ' ' ) || ( *pDest == 0x9 ) )
pDest++;
i.e. means...
while ( (( --nSecurityCount ) && ( *pDest == ' ' )) || ( *pDest == 0x9 ) )
pDest++;
source/filter.vcl/ieps/ieps.cxx
while ( ( --nSecurityCount ) && ( **pBuf == ' ' ) || ( **pBuf == 0x9 ) )
(*pBuf)++;
i.e. means
while ( (( --nSecurityCount ) && ( **pBuf == ' ' )) || ( **pBuf == 0x9 ) )
(*pBuf)++;
and
if( bEnlarge &&
rCropLeftTop.Width() < 0 ||
rCropLeftTop.Height() < 0 ||
rCropRightBottom.Width() < 0 ||
rCropRightBottom.Height() < 0 )
i.e. means
if( (bEnlarge &&
rCropLeftTop.Width() < 0) ||
rCropLeftTop.Height() < 0 ||
rCropRightBottom.Width() < 0 ||
rCropRightBottom.Height() < 0 )
Those meanings look very suspicious to me, I suspect that the intention is as
the attached patch changes them to be.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
