To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96112
Issue #|96112
Summary|sw: ambiguous && ||
Component|Word processor
Version|DEV300m35
Platform|All
URL|
OS/Version|Linux
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|PATCH
Priority|P3
Subcomponent|code
Assigned to|ama
Reported by|cmc
------- Additional comments from [EMAIL PROTECTED] Tue Nov 11 16:49:42 +0000
2008 -------
In sw/source/ui/uiview/srcview.cxx
we have
if ( rHint.ISA(SfxSimpleHint) &&
(((SfxSimpleHint&) rHint).GetId() == SFX_HINT_MODECHANGED) ||
(((SfxSimpleHint&) rHint).GetId() == SFX_HINT_TITLECHANGED &&
!GetDocShell()->IsReadOnly() && aEditWin.IsReadonly()))
operator precedence means that this means...
if (
(
rHint.ISA(SfxSimpleHint) &&
(((SfxSimpleHint&) rHint).GetId() == SFX_HINT_MODECHANGED)
) ||
(
((SfxSimpleHint&) rHint).GetId() == SFX_HINT_TITLECHANGED &&
!GetDocShell()->IsReadOnly() && aEditWin.IsReadonly()
)
)
which doesn't look quite right, in that if rHint fails ISA SfxSimpleHint then we
move to the other leg and cast it to a SfxSimpleHint anyway.
Not sure what we actually intend here, attached is one possibility.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
