To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96087
                 Issue #|96087
                 Summary|basic: ambiguous && || sequence
               Component|scripting
                 Version|DEV300m35
                Platform|All
                     URL|
              OS/Version|Linux
                  Status|NEW
       Status whiteboard|
                Keywords|
              Resolution|
              Issue type|PATCH
                Priority|P3
            Subcomponent|code
             Assigned to|kr
             Reported by|cmc





------- Additional comments from [EMAIL PROTECTED] Tue Nov 11 10:35:30 +0000 
2008 -------
X && Y || Z
binds operator precedence-wise as
(X && Y) || Z
not
X && (Y || Z)

so I am a little suspicious about...

in basic/source/sbx/sbxexec.cxx
while( *p && rCharClass.isAlphaNumeric( *p ) || *p == '_' )
which really means...
while( (*p && rCharClass.isAlphaNumeric( *p )) || *p == '_' )
while
while( *p && (rCharClass.isAlphaNumeric( *p ) || *p == '_' ))
seems the more likely desired meaning ?

similarly 
while( refVar.Is() && *p == '.' || *p == '!' )
means
while( (refVar.Is() && *p == '.') || *p == '!' )
while
while( refVar.Is() && (*p == '.' || *p == '!') )
seems more the likely intent ?

and finally in
basic/source/comp/scanner.cxx
while( *pLine && ( *pLine == ' ' ) || ( *pLine == '\t' ) || ( *pLine == '\f' ) )
means
while( (*pLine && ( *pLine == ' ' )) || ( *pLine == '\t' ) || ( *pLine == '\f' 
) )
but I suspect
while( *pLine && (( *pLine == ' ' ) || ( *pLine == '\t' ) || ( *pLine == '\f' ) 
))
is what we want.

Patch attached to change to what I *suspect* we might mean.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to