To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96163
Issue #|96163
Summary|sd: ambiguous && ||
Component|Drawing
Version|DEV300m35
Platform|All
URL|
OS/Version|Linux
Status|NEW
Status whiteboard|
Keywords|
Resolution|
Issue type|PATCH
Priority|P3
Subcomponent|code
Assigned to|graphicsneedsconfirm
Reported by|cmc
------- Additional comments from [EMAIL PROTECTED] Wed Nov 12 16:36:57 +0000
2008 -------
In three places
source/filter/grf/sdgrffilter.cxx
source/ui/view/drviews8.cxx
source/ui/view/drviews9.cxx
we have the pattern of..
if ((aSize.Height() > aPageSize.Height()) ||
(aSize.Width() > aPageSize.Width()) &&
aSize.Height() && aPageSize.Height())
which by operator precedence is equivalent to
if (
(aSize.Height() > aPageSize.Height()) ||
(
(aSize.Width() > aPageSize.Width()) &&
aSize.Height() && aPageSize.Height()
)
)
That doesn't looks quite right, I suspect we intend
if (
(
(aSize.Height() > aPageSize.Height()) ||
(aSize.Width() > aPageSize.Width())
) &&
aSize.Height() && aPageSize.Height()
)
If so, then the attached patch fixes the three places using this pattern.
Otherwise some extra brackets to make the logic explicit might be called for
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
