To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=97208 Issue #|97208 Summary|accelerate make_installer #2 Component|tools Version|DEV300m37 Platform|Unknown URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|mh Reported by|mmeeks
------- Additional comments from [email protected] Fri Dec 12 15:30:54 +0000 2008 ------- So - the variable substitution we do is deadly slow; regexps are expensive - we do a lot of them on each line, when conceptually there is no reason not to do them for the whole file. If instead we concatenate the strings into a single blob and do the regexps once we get: %Time ExclSec CumulS #Calls sec/call Csec/c Name before: 33.4 2.030 2.030 1 2.0300 2.0300 installer::setupscript::replace_al l_setupscriptvariables_in_script after: 6.43 0.240 0.240 1 0.2400 0.2400 installer::setupscript::replace_al l_setupscriptvariables_in_script ie. 2 seconds faster. In addition I added some warnings that catch bogus substitutions, it turns out (cf. http://www.openoffice.org/issues/show_bug.cgi?id=97206 ) that these are all bugs too - so far I just warn rather than aborting. Oh - the code would be shorter & simpler too, but for the fact that I added the check ;-) Thanks. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
