To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96475





------- Additional comments from [email protected] Thu Jan  8 14:33:53 +0000 
2009 -------
AW: I investigated on this one.

First comment: I cannot reproduce this on my local DEV300 m37 (CWS aw061). Is
this normally simple to reproduce?

Second comment: The area invalidated is calculated using the
BasePrimitive2D::getRange functionality. This again internally uses the
decompose when ::getB2DRange is not implemented at the primitive in question. In
the current example, the decomposition from the SdrObject with thext down to
TextDecoratedPortionPrimitive2D is done (as expected).

Since TextDecoratedPortionPrimitive2D is derived from
TextSimplePortionPrimitive2D, the TextSimplePortionPrimitive2D::getB2DRange is
used to determine the text portion's range. That implementation indirectly uses
getTextBoundRect from OutputDevice, which is also correct.

When the text decoration IS used and can possibly 'stick out' of the
TextSimplePortionPrimitive2D's text range, it will be necessary to overload and
implement TextDecoratedPortionPrimitive2D::getB2DRange().

That implementation in it's simplest form could internally call
TextSimplePortionPrimitive2D::getB2DRange to get the text range, and then expand
this range by the used decorations.

An alternative to this implementation (and the more unified one since
decorations would still only be needed to be computed in one place, the
decomposition itself) could be to use the local decomposition, but please ONLY
when a decoration is used.

So, the question is:

IF text decorations CAN stick out of the TextRange (as given from
OutputDevice::getTextBoundRect) this is a task for me, and i should implement
the missing TextDecoratedPortionPrimitive2D::getB2DRange().

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to