To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=85921
User af changed the following:
What |Old value |New value
================================================================================
Target milestone|OOo 3.1 |OOo 3.2
--------------------------------------------------------------------------------
------- Additional comments from [email protected] Tue Jan 20 12:23:28 +0000
2009 -------
I finally found the time to review the patch. Late again, I am terribly sorry.
Most of the patch looks good except for the part in MasterPagesSelector.cxx.
The handling of the SID_TP_EDIT_MASTER slot relies solely on the slide sorter
for switching to master mode and then for switching to the selected master page.
This is not the right way to do it. I am even surprised and, as the author of
the slide sorter, somewhat pleased that this works at all.
Better use something like the code below to handle the slot. It first
dispatches slot SID_MASTERPAGE (synchronously) to switch to master mode. After
that the XDrawController::setCurrentPage(.) method is used to switch to the
selected master page:
case SID_TP_EDIT_MASTER:
{
using namespace ::com::sun::star;
uno::Reference<drawing::XDrawPage> xSelectedMaster (
GetSelectedMasterPage()->getUnoPage(), uno::UNO_QUERY);
SfxViewFrame* pViewFrame = mrBase.GetViewFrame();
if (pViewFrame != NULL && xSelectedMaster.is())
{
SfxDispatcher* pDispatcher = pViewFrame->GetDispatcher();
if (pDispatcher != NULL)
{
USHORT nIndex = mpPageSet->GetSelectItemId();
pDispatcher->Execute(SID_MASTERPAGE, SFX_CALLMODE_SYNCHRON);
mpPageSet->SelectItem (nIndex);
mrBase.GetDrawController().setCurrentPage(xSelectedMaster);
}
}
break;
}
I have submitted issue 98272 for an assertion that is triggered when the
previews are created and that makes testing and debugging the code above harder
than necessary.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
