To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=87596
------- Additional comments from [email protected] Wed Feb 18 09:55:28 +0000 2009 ------- See my comments in issue 98805 for more info on the background of this bug. The attached file is not really a patch, but it proves we have a problem with window decorations here. First, the general idea is that model geometry information, denoted in MAP_APPFONT, does not take into account window decoration, i.e. the window border and the title bar. This makes sense, since the decoration depends on the concrete graphical system the dialog is displayed on. Contrary, the geometry information at a control (XWindow), denoted in pixel, does take window decoration into account. Now, there is a place in toolkit where control geometry is "translated" into model geometry: UnoDialogControl::windowResized in toolkit/source/controls/dialogcontrol.cxx. This method cares for subtracting the window decoration. (which is what the fix for issue 84487 added) The place where model geometry is translated into control geometry is in UnoDialogControl::ImplSetPosSize (same file). This place currently does *not* respect window decoration at all. The patch adds a few lines which take the window decoration into account, in ImplSetPosSize. This fixes both this issue here, and issue 98805. Sadly, there's still something wrong: Dialogs now appear a little bit too large, both when executed programmatically, and when executed from within the dialog editor. More precise: "a little bit" too large means: it's as if the window decoration has been added once too often ... This is the place which I currently do not understand, and which means the half.a.patch is, well, only half a patch :) I'll stop investigating here for the moment - finally, Carsten, it's your issue, isn't it? :) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
