To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99010
------- Additional comments from [email protected] Wed Feb 25 12:57:31 +0000 2009 ------- ->cd: notice that a fix for layoutimpl::VCLXDialog::dispose() [ http://svn.services.openoffice.org/opengrok/xref/DEV300_m41/toolkit/source/awt/vclxdialog.cxx#106 ], is still missing. In theory, the fix is rather trivial and simply: =================================================================== --- ../toolkit/source/awt/vclxdialog.cxx (revision 267005) +++ ../toolkit/source/awt/vclxdialog.cxx (working copy) @@ -113,6 +113,7 @@ // maTabListeners.disposeAndClear( aDisposeEvent ); } + VCLXTopWindow_Base::cleanUpMenuBar(); VCLXWindow::dispose(); } but although I've tried different things this weekend, I re-builded enabling layout, but couldn't make the test on toolkit/workben/layout run (I always get a css.uno.RuntimeException no matter what I try). In practice, setting a MenuBar on a Dialog has no effect at all: in SystemWindow::SetMenuBar() the condition [http://svn.services.openoffice.org/opengrok/xref/DEV300_m41/vcl/source/window/syswin.cxx#913] evaluates always to false, because mpWindowImpl->mpBorderWindow is a null pointer [a Dialog has no Border Window]; also http://svn.services.openoffice.org/opengrok/xref/DEV300_m41/vcl/source/window/syswin.cxx#956 evaluates to false, so here there is no life-time issue due to the MenuBarWindow holding a pointer to a dead parent In theory layoutimpl::VCLXDialog::dispose() should call VCLXTopWindow_Base::cleanUpMenuBar(); I just could find the way to test it works. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
