To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99765 Issue #|99765 Summary|i18npool: isShort test looks a little strange... Component|l10n Version|DEV300m42 Platform|All URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|i18npool Assigned to|er Reported by|cmc
------- Additional comments from [email protected] Mon Mar 2 09:09:27 +0000 2009 ------- in i18npoo/source/calendar/calendar_gregorian.cxx we have... sal_Bool isShort = (nCalendarDisplayCode == CalendarDisplayCode::SHORT_YEAR || nCalendarDisplayCode == CalendarDisplayCode::LONG_YEAR) && value >= 100 || nCalendarDisplayCode == CalendarDisplayCode::SHORT_QUARTER || nCalendarDisplayCode == CalendarDisplayCode::LONG_QUARTER; which looks a little strange, "isShort". Attached is version1 which keeps things exactly as they are, except adding some brackets to keep new gcc quiet. But the isShort = (_YEAR && value >= 100) looks kind of odd, is that really what we want ? Not e.g. isShort == SHORT_YEAR || (LONG_YEAR && value < 100) ? --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
