To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=99577
------- Additional comments from [email protected] Wed Mar 4 01:04:46 +0000 2009 ------- I like it :-) What isn't exactly clear to me are the changes in desktop/source/app/langselect.cxx and how they fit with issue 42730 and its specification. Removal of LanguageSelection::setDefaultLocale() there seems to disable setting the config's DefaultLocale_CTL language for example to Thai if that was the "Language for non-Unicode programs" legacy 16-bit locale under Windows (see screen shot in spec), that is done even if the Regional Setting's locale is en-US. MsLangId::resolveSystemLanguageByScriptType(...,COMPLEX) then will resolve to a different locale LANGUAGE_HINDI, if I didn't overlook something. Similar for DefaultLocale_CJK. To solve this, it may be necessary to make LanguageSelection::setDefaultLocale() pass the CTL and CJK locales down to MsLangId, similar to MsLangId::setConfiguredSystemLanguage(), and use those values in calls to MsLangId::resolveSystemLanguageByScriptType() as fall-backs if set. Also, reading the DefaultLocale* config values later would result in an empty locale, maybe the CJK/CTL option being treated as disabled, so code not aware of this change would fail, respectively not match the new behavior, even for the non-CJK/CTL case, I don't think code is prepared to receive an empty==system locale there. A quick check in m41 using id-utils lid --key=none --separator=newline --regexp 'DefaultLocale_(CJK|CTL)' | sort revealed binfilter/bf_sch/source/core/sch_chtmodel.cxx binfilter/inc/bf_svtools/linguprops.hxx chart2/source/tools/CharacterProperties.cxx desktop/source/app/langselect.cxx reportdesign/source/core/api/ReportComponent.cxx svtools/inc/linguprops.hxx svx/source/dialog/optgdlg.cxx sw/source/ui/app/appopt.cxx binfilter here is moot.. others probably are not. A search on non-CJK/CTL DefaultLocale didn't reveal further files. svtools/inc/linguprops.hxx defines UPN_DEFAULT_LOCALE* that are used in binfilter/bf_svtools/source/config/svt_lingucfg.cxx binfilter/inc/bf_svtools/linguprops.hxx linguistic/source/lngopt.cxx svtools/inc/linguprops.hxx svtools/source/config/lingucfg.cxx --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
