To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100177 Issue #|100177 Summary|performance: impl_ts_getLocale result should be reused Component|framework Version|OOO310m5 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|code Assigned to|cd Reported by|hdu
------- Additional comments from [email protected] Fri Mar 13 12:22:19 +0000 2009 ------- While debugging into issue 98052 and issue 100172 it showed that the method impl_ts_getLocale() is reponsible for almost half of the multi-second wait because the underlying configmgr is so slow. The header file comments that > We does not cache this value, because we are not listen for changes on the > configuration layer ... but it is easily possible to reduce the 140 expensive invokations to 4 without loosing anything by moving the expensive call outside the inner loop in impl_ts_load(). On this dualcore 2GHz system the patch below saves more than a second: --- a/framework/source/accelerators/acceleratorconfiguration.cxx +++ b/framework/source/accelerators/acceleratorconfiguration.cxx @@ -1247,2 +1245,3 @@ css::uno::Sequence< ::rtl::OUString > lKeys = xAccess->getElementNames(); + const ::rtl::OUString sLocale = impl_ts_getLocale().toISO(); sal_Int32 nKeys = lKeys.getLength(); @@ -1264,1 +1262,1 @@ - if ( *pFound == impl_ts_getLocale().toISO() ) + if ( *pFound == sLocale ) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
