To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100273
------- Additional comments from [email protected] Wed Mar 18 11:22:12 +0000 2009 ------- "I would like to extend the fix with the alternative hyphenation support (using hyphenate3 call instead of hyphenate), too." Ummm, looking into this: hnj_hyphenate (as used around the code of the patch) returns the "hyphenated word" in the same encoding of the "word", and returns hyphens with indexes to the bytes where the hyphens are to placed in the encoded-word But hnj_hyphenate2 and hnj_hyphenate3 return the "hyphenated word" in the same encoding as the "word", but then have a sort of magic-fixup thing for the rep/pos/cut where those indexes are *not* returned as indexes into the bytes of the input string where the hyphenation information should go, but are instead logical indexes into an idealized "character position" which effectively maps them to the position where the original positions would be in the OOo unicode string. i.e. The hyphens etc of hnj_hyphenate are returned relative to the encoded input string, while those of hnj_hyphenate2 and hnj_hyphenate3 are returned relative to the original string before it was encoded. So is there actually a reproducible problem with the hnj_hyphenate3 related call ? (Though personally I'd have all the hnj_* functions return data relative to the bytes of the encoded input string, drop the hnj_hyphen_norm stuff because it only has support for utf-8, and not other variable length multi-byte encodings like e.g. utf-7 or shift-jis and then build up the strings and positions for the OOo unicode string like this patch does for the hnj_hyphenate call, but that's probably out-of-scope for the moment) --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
