To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=100481 Issue #|100481 Summary|svx: ambiguous && and || Component|Drawing Version|DEV300m44 Platform|All URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|ka Reported by|cmc
------- Additional comments from [email protected] Mon Mar 23 13:52:00 +0000 2009 ------- X && Y || Z binds operator precedence-wise as (X && Y) || Z not X && (Y || Z) so I am a little suspicious about... source/dialog/numpages.cxx where we have repeated patterns of... if(bPreset || bModified && pActNum) *pSaveNum = *pActNum; i.e. its clearly unsafe to dereference pActNum if it is NULL if bPreset if true and bModified is false, but that is what would happen at the moment. Are we sure that's what we want, if not the attached patch fixes them up. Also note the first instance tests off pSaveNum which is different to the normal pattern of testing pActNum, but otherwise the code is the same, which is also suspicious --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
