To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=96918





------- Additional comments from [email protected] Wed Apr 15 16:21:09 
+0000 2009 -------
haggai->mav:

> mav->haggai: Thank you for the investigation. Sorry, but the attached patch is
> just a hack that would break the behavior in case system file locking is 
> turned
> off. 

Okay, we hadn't run through the full set of tests yet to determine if anything
else had broken as a result of the patch. That was why I posted the patch for
your comments before going further :)

> The real problem, as you already have already written, is in
> implementation/usage of osl_getFileStatus() call. This problem should be fixed
> even if the default configuration works well in OOo3.1, since it is 
> possible to turn the system file locking off, and then we would have just 
> the same problem.

I don't think you can rely on osl_getFileStatus, instead of opening the file as
writable. You'll always have potential race conditions, where the state of the
file changes between the calls. Or are you thinking of using osl_getFileStatus
to see if you could open it as writable, then handle an error in the race
condition case if you then find it is no longer writeable?


---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to