To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=102260





------- Additional comments from [email protected] Mon Jun  8 12:33:51 +0000 
2009 -------
hbrinkm: I have no example documents :-)  It is apparent from reading the code
that either the intention was what's in the patches, or the code around the
patches is wrong.  You are right that having a document would be best to see 
what
is the correct answer...  I mean:

If the first patch is incorrect, there should be no sStr =
FieldString(ww::eFILLIN);, it is overridden by ASSIGN_CONST_ASC().

Patch 2 actually takes ooxml03 changes into account; anyway, the corresponding
code without ooxml03 changes looks like:

        sal_Unicode cStart = rAttr.GetStartBracket();
        sal_Unicode cEnd = rAttr.GetStartBracket();
        USHORT nType;
        if (!cStart && !cEnd)
            nType = 0;
        else if ((cStart == '{') || (cEnd == '}'))
etc.

in which case there's no need for any cEnd if the 2nd patch is not correct.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to