To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101552
------- Additional comments from [email protected] Mon Jun 8 15:17:58 +0000 2009 ------- @yanminjia: It looks much better, thanks! It is still very expensive though: - unfortunately the GetDevFontList() call is relatively expensive in this context. It does way to much copying. For the existing use cases it just was not worth it to do more sharing => I suggest to use the ImplDevFontList directly (knowing that all entries there are WinFontData objects) and ignoring any non- scalable entries - the first part of the loop in FindFontSubstitute() where it gets the font face details (by calling UpdateFromHDC()) is not needed when it is already known for that WinFontData object. Testing if the details are already known maybe deserves a helper function. Or it can be done by calling ImplWinFontData::GetImplFontCharMap() which has been modified a bit to also allow a NULL return --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
