To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=104280 Issue #|104280 Summary|xmloff: lcl_IsAtEnd logic is inverted Component|xml Version|DEV300m54 Platform|All URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|mba Reported by|cmc
------- Additional comments from [email protected] Mon Aug 17 11:06:18 +0000 2009 ------- xmloff/source/style/xmlnumfi.cxx if ( nTokLen > nBufLen ) return sal_False; sal_Int32 nStartPos = nTokLen - nBufLen; for ( xub_StrLen nTokPos = 0; nTokPos < nTokLen; nTokPos++ ) if ( rToken.GetChar( nTokPos ) != rBuffer.charAt( nStartPos + nTokPos ) ) almost certainly given that nBufLen is > nTokLen then we meant to have sal_Int32 nStartPos = nBufLen - nTokLen; in there. valgrind spews warnings about it --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
