To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=101455
User sb changed the following:
What |Old value |New value
================================================================================
Status|RESOLVED |REOPENED
--------------------------------------------------------------------------------
Resolution|FIXED |
--------------------------------------------------------------------------------
------- Additional comments from [email protected] Tue Sep 1 11:32:55 +0000
2009 -------
@mba: The modification of idl/source/objects/bastype.cxx in
<http://hg.services.openoffice.org/hg/cws/mba32issues02/rev/53b0444724da> is
still not correct:
- it fails to multiply the final result assigned to *pValue by nSign;
- it arbitrarily fails for LONG_MIN;
- technically speaking, it incurs undefined behavior when casting between long
and unsigned long;
- it violates our coding standards (tabs, C-style casts).
As the only call to ReadRangeSvIdl is with nMin == 0, why not simply drop
support for reading negative numbers in the first place and simplify
accordingly?
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
