To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=103899
User nn changed the following:
What |Old value |New value
================================================================================
CC|'' |'pl'
--------------------------------------------------------------------------------
------- Additional comments from [email protected] Wed Sep 16 17:16:54 +0000
2009 -------
Thanks a lot for this code! I think the next steps are:
- The patch seems to be based on something before DEV300m49. There have been
some changes (like issue 45291) that interfere with your changes. You should
always use a milestone as current as possible.
- We compile with "warnings as errors", so we have to make sure the code
compiles without warnings at least on the main platforms.
- Things like commented-out code, or includes in the middle of files should be
cleaned up.
- Philipp (pl) probably wants to look at the vcl changes and comment on them.
- With the size of the changes, perhaps it's better to create a CWS instead of
making updated patches. Do you know how to create a CWS?
Some of the code looks unnecessarily complex. For example, is everything from
typecast.h and refimpl.h only intended for the Mutex in the dialog, or are these
general helpers that will also be used in upcoming patches?
Then, some details:
- A new child window needs a slot definition (in the sdi files).
- validate.obj ends up in both sc and scui libs now.
I suppose more will come up, but let's get the bigger points out of the way
first.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
