To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105626 Issue #|105626 Summary|framework: can't add menu to toolbar Component|framework Version|DEV300m58 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|cd Reported by|npower
------- Additional comments from [email protected] Mon Oct 5 20:24:01 +0000 2009 ------- Hi Carsten, I am attaching here a couple of enhancements for toolbars / menu(s) that I would like to get reviewed ( opinions on, help etc. ) I hope you are interested in this So, whats it all about, o Currently it is not possible to add ( programatically ) a menu to a custom toolbar ( and if it is I have wasted alot of time :-/ ) o It is not possible to define whether a toolbar ( or menu ) item displays text, icon or text&icon type styles ( e.g. for menu there is a global setting that defines this and for the toolbar there is a setting per toolbar ). o The tooltip for a toolbar item is defined by the label/command. All of the functionality described above are behaviour that I need ;-) However, not being any sort of framework expert I have cobbled together a patch of sorts that attempts addresses the issues above. I'm looking for help/support upstreaming this and I look for advice about a number of things to do with the patch particually a) I have introduced a new property to the property sequence for creating a toolbar item, this property is used to define a seperate Tooltip. However after looking at the code I noticed that the HelpURL doesn't seem to be used at all, so... could the HelpURL be recycled to define the tooltip? b) Similarly I currently reuse the ICON style property to override the global menu setting for displaying icons in a menu and use the same property again in the context of a toolbar item to do the same. Additionally I have added a new constant css::ui::ItemStyle::TEXT for a similar purpose to css::ui::ItemStyle c) to hold the menu information of the menu to be dropped by a toolbar item I use the existing menubar container ( and associated configuration ) 1 settings container per dropdown, e.g. the settings container just contains a single entry/popup ) - perhaps this is wasteful ( an alternative would be to have a settings container per custom toolbar but.... I did like the fact the menubar is retrievable by name, additionally from a conceptual point of view especially in the interoperability case the dropdown *is* a menubar. d) where possible I have resused the existing infrastucture, but not being all that familiar with this stuff my implementation maybe more complex than needed, would be good to get some advice about that too attached is a test document that you can play with that show the usage, additionally persistance of the items above is also implemented ( note: in the example document you need to explicitly/manually run the 'Persist' macro before tring to save a document with those settings. p.s. the patch is based of dev300m58 --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
