To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91504
------- Additional comments from [email protected] Fri Oct 16 13:06:17 +0000 2009 ------- hi majun51, so the code that tries to display the redline in SwUndoRedlineSort::_Undo calls Show(), which is actually Show(0), which does not actually do anything at all? ouch... clearly this code has never been tested. Thanks for pointing out that redlines that are in the start/end paragraph but not in the selection get lost; i had not noticed that. I believe it should be sufficient to just expand the PaM in SwDoc::SortText so it selects the whole start and end paragraphs, because, after all, this function sorts whole paragraphs. (probably best to do this after SortText has checked that all nodes are text nodes) Furthermore, with this change, you should not need the new members for storing the selection start/end index, because these indices are then always 0 and pEndNode->Len(). That should be much simpler, and we do not complicate the undo object with this. Can you try out whether this works? --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
